On Tue, Aug 18 2015 at 3:04am -0400, Ming Lin <mlin@xxxxxxxxxx> wrote: > On Mon, Aug 17, 2015 at 10:09 PM, Ming Lin <mlin@xxxxxxxxxx> wrote: > > On Mon, Aug 10, 2015 at 8:02 AM, Mike Snitzer <snitzer@xxxxxxxxxx> wrote: > >> p.s. I'll be working with Joe Thornber on optimizing DM (particularly > >> dm-thinp and dm-cache) once this patchset is included upstream. You'll > >> see I've already added a couple WIP dm-thinp patches ontop. > > > > Hi Mike, > > > > Just to avoid duplicated work. > > Are you going to work on the dm-thinp/dm-cache discard rewritten? > > Seems dm-stripe discard also needs rewrite. Can you elaborate on what you feel needs re-writing in these targets? This is the basic initial cleanup I had in mind for dm-thinp: http://git.kernel.org/cgit/linux/kernel/git/snitzer/linux.git/commit/?h=dm-4.4&id=cb0aca0a6bfad6b7f7146dde776f374082a73db6 A much more involved refactoring of the dm-cache and dm-thinp targets to eliminate the need for splitting will involve bio-prison range locking and a new metadata format for both targets to express ranges as opposed to blocks. This line of work is on Joe's radar but it is much further out given the associated on-disk metadata format change. That aside, I do need to look at DM core to see how we can do things differently so that block core's bio_split() et al is doing the splitting rather than DM core having a role. I'd prefer to be the one working these DM changes. But if you have ideas of how things should be cleaned up I'd be happy to consider them. Thanks, Mike -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
