On Thu, Jun 18, 2015 at 03:28:21PM -0400, Mike Snitzer wrote: > > WARN_ON_ONCE(write_inode_now(inode, true)) > > > > If we failed to write back inode, then warning about it sounds right? > > A warning is fine.. not a WARN_ON(). Pretty alarming backtrace spew but > maybe I'm missing something and DM's blkdev refcount mgmt couldn't > trigger this WARN_ON()? I fail to see how to avoid it given the device > isn't thre so write_inode_now() fails. > > > What's wrong with that? Should it be just a kernel log of level KERN_WARN > > instead? > > Ideally, but I honestly don't have all the details paged in my head to > say definitively. First need to answer how vitrio-blk isn't hitting > this (and DM is). Could it be that __blkdev_put isn't getting called > for virtio-blk!? Just a warnings if fine. In fact we can probably remove that as well as it will happen after a hot removal all the time. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
