On Wed, Jun 10 2015 at 11:26am -0400, Mike Snitzer <snitzer@xxxxxxxxxx> wrote: > On Wed, Jun 10 2015 at 4:11am -0400, > Christoph Hellwig <hch@xxxxxx> wrote: > > > On Thu, Jun 04, 2015 at 11:31:07AM -0400, Mike Snitzer wrote: > > > This patch _really_ concerns me because just in DM alone I found you > > > took liberties that you shouldn't have and created a regression. First > > > issue is a real bug (your proposed dm-io.c:dmio_complete change missed > > > that dm-io uses error_bits and not traditional error code like expected) > > > > Point taken. I already wanted to complain about the mess due to the bio > > error abuse with it's own values in DM in the first posting, guess I > > need to add that to the second one. I don't think overloading common > > interfaces with your private error codes is a good idea, but let's > > leave that for a separate discussion. > > I'll queue a patch to rename 'error' to 'error_bits' where appropriate. See: https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=f368f463e4cef696ad6b102dbaf5c10dfca7cc63 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
