On Mon, May 18 2015 at 4:29am -0400, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Thu, May 14, 2015 at 05:05:04PM -0400, Mike Snitzer wrote: > > More often than not a request that is requeued _is_ mapped (meaning the > > clone request is allocated and clone->q is initialized). Rename > > dm_requeue_unmapped_original_request() and dm_requeue_unmapped_request() > > to avoid potential confusion due to function names containing "unmapped". > > Can you also just kill off dm_requeue_unmapped_request / dm_requeue_request > while you're at it? Both callers have the dm_rq_target_io at hand, > so it's rather poinless. Good point, will do. > Also for the blk-mq case please just return BLK_MQ_RQ_QUEUE_BUSY from > ->queue_rq insted of requeing the request. I'll make a note to revisit this (need to audit what, if any, implications doing so has). -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
