On Thu, May 14, 2015 at 05:05:02PM -0400, Mike Snitzer wrote: > From: Joe Thornber <ejt@xxxxxxxxxx> > > Useful for callers who wish to manage the async completion of discard(s) > without explicitly blocking waiting for completion. > > blkdev_issue_discard() is updated to call blkdev_issue_discard_async() > and DM thinp will make use of blkdev_issue_discard_async() in the > upcoming "dm thin: range discard support" commit. I think this is the wrong level of interface. I think dm should just submit the bios directly, which will also allow it to use bio_chain properly instead of needing the inc_remaining hack. Instead export helpers that properly split up the discard chunk sectors without touching the bio itself. And with bio split on demand work even that will hopefully go away soon. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel