On 05/11/2015 08:55 AM, Christoph Hellwig wrote: > On Mon, May 04, 2015 at 02:42:14PM +0200, Hannes Reinecke wrote: >> We should be issuing STPG synchronously as we need to >> evaluate the return code on failure. > > How does this fit into the calling convention? It seems like generally > dm-mpath expects async execution of ->activate. If we don't actually need > asynchronous activation we should remove it from all the drivers to have > a consistent calling convention. > This is just an intermediate step, before the entire thing moves off to a workqueue and becomes asynchronous again. It's not meant to be as a standalone patch; I've just split it off for easier review. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
