On Fri, Mar 27, 2015 at 05:03:06PM +0100, Hannes Reinecke wrote: > On 03/27/2015 04:42 AM, Benjamin Marzinski wrote: > > On Mon, Mar 16, 2015 at 01:36:13PM +0100, Hannes Reinecke wrote: > >> When all paths are failed we should not try to run any programs > >> requiring disk access. However, we still need to create the > >> symlinks so as not to confuse systemd. > >> So import the blkid values from the database in these cases. > > > > Don't we still need to set DM_NOSCAN here? > > > I have no idea at all. I just found the setting somewhere and > thought it'd be a good idea. > But don't ask me what's for; device-mapper/LVM udev variables > are an arcane subject which I've yet to grasp. But what I mean is that your patch removes DM_NOSCAN -ENV{DM_NR_VALID_PATHS}=="0", ENV{DM_NOSCAN}="1" I assume that this is an oversight, since as you mentioned, we don't want to be running blkid on a device with no valid paths. -Ben > > Incidentally, a similar fix is needed for 10-dm.rules. > But I'll prepare a separate patch for this. > > Cheers, > > Hannes > -- > Dr. Hannes Reinecke zSeries & Storage > hare@xxxxxxx +49 911 74053 688 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton > HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel