On 03/27/2015 05:10 AM, Benjamin Marzinski wrote: > On Mon, Mar 16, 2015 at 01:36:55PM +0100, Hannes Reinecke wrote: >> Due to a race condition within udev the 'uid_attribute' >> might not always be set. So we should be zeroing the >> 'uid_attribute' when retrieving the uid by other means, >> otherwise the discovery process will blacklist the device. > > Possibly I'm just missing obvious here, but I don't get the point of > zeroing out the uid_attribute. Won't it just get reset on the next call > to get_uid? > The uid_attribute setting is evaluated later on, so when we're not zeroing it the code assumes we've got the UID from the udev attribute, which is untrue. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
