On Thu, Jul 24, 2014 at 04:55:59PM +0200, Sebastian Herbszt wrote: > Bart Van Assche wrote: > > Inside libmultipath regcomp() is used to compile regular expressions > > specified in /etc/multipath.conf. Many multipath.conf examples contain > > 'product_type "*"'. However, "*" is not a valid POSIX regular expression. > > Hence this patch that changes the regular expression "*" into ".*". > > > Is this change really required? With patch 4 we now get a proper error: > multipath.conf +14 parsing failed: vendor "*" > multipath.conf +15 parsing failed: product "*" > error parsing config file > > I think it should be enough to modify the man page to mention vendor/product > are both regular expressions. This change might also confuse users since this > automagic "*" to ".*" only applies to the blacklist exceptions. Agreed; the examples are broken here so let's fix them rather than add magic parsing that will only come back to confuse people in the future. Regards, Bryn. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
