The callers of sysfs_attr_get_value() expect a '\0'-terminated string. Hence terminate the string returned by this function with '\0'. Detected by Valgrind. Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> --- libmultipath/sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libmultipath/sysfs.c b/libmultipath/sysfs.c index e5834f9..f42cda8 100644 --- a/libmultipath/sysfs.c +++ b/libmultipath/sysfs.c @@ -88,6 +88,8 @@ ssize_t sysfs_attr_get_value(struct udev_device *dev, const char *attr_name, } else if (size == value_len) { condlog(4, "overflow while reading from %s", devpath); size = 0; + } else { + value[size] = '\0'; } close(fd); -- 1.8.4.5 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel