> -----Original Message----- > From: Benjamin Marzinski [mailto:bmarzins@xxxxxxxxxx] > Sent: Wednesday, May 21, 2014 2:03 PM > To: device-mapper development > Cc: Christophe Varoqui; Merla, ShivaKrishna > Subject: [PATCH] multipath: Fix some minor issues in path reordering code > > There were a couple of small issues with the path reordering code. > > Since you may fail to get the adapter name at any time while looping > through the paths, you need to clean up when this fails, instead of > just exitting group_by_host_adapter(). > > I've looked at a couple kernels, and I don't see any sysfs file named: > /sys/class/iscsi_host/host<n>/ip_address > It's always: > /sys/class/iscsi_host/host<n>/ipaddress > > Also /sys/class/iscsi_host/host<n>/ipaddress could be an IPv6 address, > in which case we need 40 bytes to hold is, so SLOT_NAME_SIZE needs to > be 40 bytes large. > Ben, thanks for identifying and fixing these. I think I overlooked the ipaddress part as we were majorly testing on FC/SAS. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
