Re: [PATCH 2/6] dm: introduce dm_accept_partial_bio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 17 2014 at  1:43pm -0400,
Mike Snitzer <snitzer@xxxxxxxxxx> wrote:

> On Mon, Mar 17 2014 at  1:08pm -0400,
> Mikulas Patocka <mpatocka@xxxxxxxxxx> wrote:
> 
> > 
> > Regarding REQ_FLUSH - it would already crash on NULL pointer dereference 
> > when accessing *tio->len_ptr.

I realize if any of these BUG_ON checks hits the calling target code has
a bug.  I just think it a fairly harsh response to BUG the system.  But
I can let this issue go.

I do however want you to add yet another BUG_ON for any bio that isn't
meant to be sent to this interface (only one so far is REQ_FLUSH AFAIK).

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux