Hi Mike, On 02/03/2014 09:28 PM, Mike Snitzer wrote: > Hi Hannes, > > I went over all of your patches and made a few tweaks, comments, and > improvements along the way. Patch headers were modified very > slightly. > > I wasn't seeing the need for (m->queue_io << 1) + m->queue_if_no_path > in v5's "[PATCH 3/6] dm-multipath: push back requests instead of > queueing" so I simplified that and documented the change in the > header. If there is a reason for what you had please explain. > 'queue_io' is just used as a marker that I/O should be queued as pg_init is running. The intention of the stacked status was so that one could figure out by 'dmsetup status' whether I/O will be blocked or not. And for that you'd need both, 'queue_io' and 'queue_if_no_path'. But thanks for the rework. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
