On 02/04/14 05:28, Mike Snitzer wrote:
> Return early for case when no path exists, this eliminates the need for
> extra nesting for the case when a path exists (the common case).
...
> - if (pgpath) {
> - if (__pgpath_busy(pgpath))
> - goto out_unlock;
> + if (!pgpath) {
This should be "unlikely(!pgpath)".
> + if (__pgpath_busy(pgpath))
> + goto out_unlock;
The above 2 lines should be removed.
(Actually it is a comment for PATCH 1/7 but just in case.)
Other than that:
Reviewed-by: Jun'ichi Nomura <j-nomura@xxxxxxxxxxxxx>
--
Jun'ichi Nomura, NEC Corporation
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
