On 02/03/14 17:18, Hannes Reinecke wrote:
> We only need to take care to add a small delay when calling
> __pg_init_all_paths() to move processing off to a workqueue;
> pg_init_done() is run from an interrupt context and needs to
> complete as fast as possible.
...
> @@ -1217,9 +1185,11 @@ static void pg_init_done(void *data, int errors)
>
> if (!m->pg_init_required)
> m->queue_io = 0;
> -
> - m->pg_init_delay_retry = delay_retry;
> - queue_work(kmultipathd, &m->process_queued_ios);
> + else {
> + m->pg_init_delay_retry = delay_retry;
> + __pg_init_all_paths(m, 50/HZ);
> + goto out;
> + }
>
I forgot to comment on this.
Adding delay to queue_work() doesn't make it fast.
So I couldn't see why this "50/HZ" delay has to be added
and where this value comes.
--
Jun'ichi Nomura, NEC Corporation
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
