On 01/17/14 19:42, Hannes Reinecke wrote:
> @@ -908,19 +910,9 @@ static void multipath_dtr(struct dm_target *ti)
> static int multipath_map(struct dm_target *ti, struct request *clone,
> union map_info *map_context)
> {
> - int r;
> struct multipath *m = (struct multipath *) ti->private;
>
> - if (set_mapinfo(m, map_context) < 0)
> - /* ENOMEM, requeue */
> - return DM_MAPIO_REQUEUE;
> -
> - clone->cmd_flags |= REQ_FAILFAST_TRANSPORT;
> - r = map_io(m, clone, map_context);
> - if (r < 0 || r == DM_MAPIO_REQUEUE)
> - clear_mapinfo(m, map_context);
> -
> - return r;
> + return map_io(m, clone, map_context);
> }
Now multipath_map() is the only caller of map_io() and
most part of multipath_map() is moved to map_io(),
there is no reason to separate those functions.
You could fold map_io() into multipath_map().
--
Jun'ichi Nomura, NEC Corporation
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
