On Fri, Dec 20, 2013 at 06:37:20PM -0500, Mike Snitzer wrote: > Also, move 'err' member in dm_thin_new_mapping structure to eliminate 4 > byte hole (reduces size from 88 bytes to 80). ACK. But ... > @@ -766,6 +766,10 @@ static struct dm_thin_new_mapping *get_next_mapping(struct pool *pool) > > memset(m, 0, sizeof(struct dm_thin_new_mapping)); > INIT_LIST_HEAD(&m->list); > + m->quiesced = false; > + m->prepared = false; > + m->pass_discard = false; > + m->definitely_not_shared = false; > m->bio = NULL; ... this is redundant. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel