On Sun, 5 Jan 2014, Bart Van Assche wrote:
> On 01/04/14 19:06, Mikulas Patocka wrote:
> > - if (t && !t->release)
> > - pr_debug("kobject: '%s' (%p): does not have a release() "
> > - "function, it is broken and must be fixed.\n",
> > - kobject_name(kobj), kobj);
> > -
>
> Has it been considered to issue a warning if no release function has
> been defined and free_completion == NULL instead of removing the above
> debug message entirely ? I think even with this patch applied it is
> still wrong to invoke kobject_put() on an object without defining a
> release function.
>
> Thanks,
>
> Bart.
With the above patch, you don't need the release method for correct
behavior. Therefore you don't have to issue warning when it is missing.
Mikulas
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
