On Sun, Jan 05, 2014 at 05:43:56PM +0100, Bart Van Assche wrote: > On 01/04/14 19:06, Mikulas Patocka wrote: > > - if (t && !t->release) > > - pr_debug("kobject: '%s' (%p): does not have a release() " > > - "function, it is broken and must be fixed.\n", > > - kobject_name(kobj), kobj); > > - > > Has it been considered to issue a warning if no release function has > been defined and free_completion == NULL instead of removing the above > debug message entirely ? I think even with this patch applied it is > still wrong to invoke kobject_put() on an object without defining a > release function. This patch isn't going to be applied, and I've reverted the original commit, so there shouldn't be any issues anymore with this code. thanks, greg k-h -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel