On 12/18/2013 03:08 PM, Mike Snitzer wrote: > On Wed, Dec 18 2013 at 2:52am -0500, > Hannes Reinecke <hare@xxxxxxx> wrote: > >> The multipath kernel module is rejecting any map with an invalid >> device. However, as the multipathd is processing the events serially >> it will try to push a map with invalid devices if more than one >> device failed at the same time. >> So we can as well accept those maps and make sure to mark the >> paths as down. > > Why is it so desirable to do this? Reduced latency to restore at least > one valid path when a bunch of paths go down? > Without this patch multipathd cannot update the map as long is hasn't catched up with udev. During that time any scheduling decisions by the kernel part are necessarily wrong, as it has to rely on the old map. > Why can't we just rely on userspace eventually figuring out which paths > are failed and pushing a valid map down? > Oh, you can. This is what we're doing now :-) But it will lead to spurious error during failover when multipathd is trying to push down maps with invalid devices. You are also running into a race window between checking the path in multipathd and pushing down the map; if the device disappears during that time you won't be able to push down the map. If that happens during boot multipathd won't be able to create the map at all, so you might not be able to boot here. With that patch you at least have the device-mapper device, allowing booting to continue. > Are there favorable reports that this new behavior actually helps? > Please quantify how. > NetApp will have; they've been pushing me to forward this patch. Sean? BTW, SUSE / SLES is running happily with this patch for years now. So it can't be at all bad ... Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
