Looks good. Did you happen to post the accompanying userspace patches? If you pass those along, I will review that also and test them together. Once that's done, I will ACK.
brassow
On Dec 3, 2013, at 11:35 PM, dongmao zhang wrote:
> modified workqueue calls on Hayakawa's comments
>
> In the cluster evironment, cluster write has poor performance.
</snip>
> spinlock_t flush_lock;
> struct list_head mark_list;
> struct list_head clear_list;
> +
> + /*work queue for flush clear region*/
Use spaces after /* and before */
> + struct workqueue_struct *dmlog_wq;
> + struct delayed_work flush_log_work;
> + atomic_t sched_flush;
> + uint32_t integrated_flush;
> };
</snip>
> devices_rdata = kzalloc(devices_rdata_size, GFP_KERNEL);
> if (!devices_rdata) {
> DMERR("Failed to allocate memory for device information");
> @@ -246,6 +268,20 @@ static int userspace_ctr(struct dm_dirty_log *log, struct dm_target *ti,
> DMERR("Failed to register %s with device-mapper",
> devices_rdata);
> }
> +
> +
Extra newline...
The rest looks good. (Cosmetic issues like this wouldn't prevent my ACK though.)
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
