Re: [PATCH 5/8] [dm-thin] Fix a race condition between discard bios and ordinary bios.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 05, 2013 at 07:11:37PM -0500, Mikulas Patocka wrote:
> On Thu, 24 Jan 2013, thornber@xxxxxxxxxx wrote:
> > I haven't hit any stack size issues.  But the cell structures are 60
> > bytes each and putting two of them on the stack seems wasteful.  I
> > don't have enough knowledge to say this will be ok for all
> > architectures and so took the safe option.
> 
> I think it's better to put the structures on the stack (it is not that 
> much, the stack has 8k, so 120 bytes is 1/68 of the stack) and remove the 
> spinlock.

ok, will change.  Thanks for looking at this Mikulas.

- Joe

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel


[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux