On Thu, Jan 31, 2013 at 06:08:00PM -0500, Mike Snitzer wrote: > On Thu, Jan 31 2013 at 5:25pm -0500, > Kent Overstreet <kent.overstreet@xxxxxxxxx> wrote: > > > On Thu, Jan 31, 2013 at 2:17 PM, Mike Snitzer <snitzer@xxxxxxxxxx> wrote: > > > Ah, yeah I had a typo in my script. When I fixed it I get a BUG (with > > > your latest bcache code) when I try to mkfs.xfs /dev/bcache0: > > > > Heh, that's the dev branch - you don't want to be running the dev > > branch, there's a lot of buggy crap in there and it almost definitely > > corrupts data. Testing branch should be good, though. > > OK, I'll pick up changes from -testing until directed elsewhere. > > BTW, here are couple things I've noticed with bcache: > > - The log messages seem to have an extra newline at the end. How are you seeing that/which log messages? I hadn't noticed that myself (do they not get printed somehow?) > - bcache doesn't appear to be establishing proper holders on the devices > it uses for the backing and cache devices. > - lsblk doesn't show any associations with bcache devices. How's that created - what function am I looking for? > - the fio utility isn't able to get any stats for the bcache device or > the devices bcache uses. I'd been meaning to fix that, never got around to figuring out how those stats are generated. Function/file you can point me to? > - if I 'stop' a bcache device (using sysfs) while it is mounted; once I > unmount the filesystem the device that bcache was using as a cache > still has an open count of 1 but the bcache device then no longer > exists You mean the backing device isn't open, just the cache device? That's intended behaviour, backing and cache devices have separate lifetimes (and you can attach many backing devices to a single cache). You just have to stop the cache set separately, via /sys/fs/bcache/<uuid>/stop or /sys/block/<cache device>/bcache/set/stop -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
