On 12/20/2012 05:10 PM, Darrick J. Wong wrote:
On Thu, Dec 20, 2012 at 08:24:59AM -0500, Mike Snitzer wrote:
On Thu, Dec 20 2012 at 7:57am -0500,
Heinz Mauelshagen <heinzm@xxxxxxxxxx> wrote:
Darrick,
thanks for testing.
Bug's a superfluous increment of the number of allocated cache
blocks in dm-cache-policy-basic:load_mappings().
Patch is attached and on my git@xxxxxxxxxx:lvmguy/linux-2.6, branch
dm-devel-cache.
FYI, I merged the fix into my dm-devel-cache too.
kbuild had this to say:
drivers/md/dm-cache-policy-basic.c: In function ‘basic_map’:
drivers/md/dm-cache-policy-basic.c:1252:39: warning: ‘tqe’ may be used uninitialized in this function [-Wuninitialized]
drivers/md/dm-cache-policy-basic.c:1271:28: note: ‘tqe’ was declared here
I _think_ it's actually ok, but I'm not 100% sure.
Aware of that and it is ok, _but_ I want to rephrase the code to get rid
of it.
Otherwise it seems to have passed the remove/recreate test.
Nice.
I'll keep pounding
on it.
Cool, thanks.
Heinz
--D
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
--
===============================================================
Heinz Mauelshagen +49 2626 141200
Consulting Development Engineer FAX +49 2626 924446
Red Hat GmbH
Am Sonnenhang 11
56242 Marienrachdorf
Germany heinzm@xxxxxxxxxx
===============================================================
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
