On 2012-11-22T14:27:52, Guangliang Zhao <gzhao@xxxxxxxx> wrote: Hi Guangliang, thanks for adding this. I think this approach is a good direction to take, just one feedback: > Add ioctl to control resync speed, userspace tool > is dmsetup message, message format is: > dmsetup message $device 0 "set $speed" > e.g. > dmsetup message /dev/dm-2 "set 12345" I think this should be "set-max-resync-rate" or something; "set" is very generic and not very extensible going forward, should the need arise. Regards, Lars -- Architect Storage/HA SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 21284 (AG Nürnberg) "Experience is the name everyone gives to their mistakes." -- Oscar Wilde -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel