>On Thu, Nov 15, 2012 at 04:46:59PM +0800, majianpeng wrote: >> So add a func dm_md_stop to clear up resource. > >> +++ b/drivers/md/md.c > >> +void dm_md_stop(struct mddev *mddev) >> +{ >> + md_stop(mddev); >> + bitmap_destroy(mddev); >> + if (mddev->bio_set) >> + bioset_free(mddev->bio_set); >> +} >> +EXPORT_SYMBOL_GPL(dm_md_stop); > >Let's not put a function with a dm_ prefix in an md file? > >Alasdair > Can you give me a hint? My thought is this func only by dm to call and there was a md_stop already? I firstly want to add those statements in dm driver like md_stop rather than a func include those. But i think dm don't know to much. Neil, your suggestion? Jianpeng Thanks! -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel