On Fri, Sep 14, 2012 at 10:50:59PM +0100, Alasdair G Kergon wrote: > On Thu, Sep 06, 2012 at 03:35:02PM -0700, Kent Overstreet wrote: > > Previously, there was bio_clone() but it only allocated from the fs bio > > set; as a result various users were open coding it and using > > __bio_clone(). > > Explain in the header the reasoning behind the change to dm-crypt so that > it no longer resets bi_idx to 0 too? > > > - clone->bi_idx = 0; Previously, it was open coding __bio_clone(), that's what the setting bi_idx to 0 was from. With the change to bio_clone_bioset() that's no longer necessary (and dangerous, since bi_idx needs to be consistent with bi_sector/bi_size). -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
