On Fri, Sep 07, 2012 at 01:44:01PM -0700, Kent Overstreet wrote: > Previously, dm_rq_clone_bio_info needed to be freed by the bio's > destructor to avoid a memory leak in the blk_rq_prep_clone() error path. > This gets rid of a memory allocation and means we can kill > dm_rq_bio_destructor. > > The _rq_bio_info_cache kmem cache is unused now and needs to be deleted, > but due to the way io_pool is used and overloaded this looks not quite > trivial so I'm leaving it for a later patch. Acked-by: Alasdair Kergon <agk@xxxxxxxxxx> > +/* > + * Unused now, and needs to be deleted. But since io_pool is overloaded and it's > + * still used for _io_cache, I'm leaving this for a later cleanup > + */ Please avoid "I" in a source file unless you are the author of the file or put your name after your comments. An unattributed "FIXME" style of comment here would be fine. Alasdair -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
