On Wed, Aug 22, 2012 at 01:00:32PM -0700, Tejun Heo wrote:
> Hello,
>
> On Wed, Aug 22, 2012 at 10:04:02AM -0700, Kent Overstreet wrote:
> > +#define BIO_KMALLOC_POOL NULL
>
> I would much prefer just doing
>
> if (!bs) {
> /* do kmalloc/kfree thing */
> } else {
> /* do bioset thing */
> }
>
> NULL @bs indicating no bioset is perfectly natural and so is using
> generic memory allocation in the absense of bioset. I don't see any
> value in defining Bio_KMALLOC_POOL to be NULL.
Eh, kind of disagree but at this point I don't care that much, I'll
change it.
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
