On Wed, Jun 20 2012 at 5:37pm -0400, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: > On Wed, Jun 20, 2012 at 05:20:10PM -0400, Vivek Goyal wrote: > > On Wed, Jun 20, 2012 at 03:24:59PM -0400, Mike Snitzer wrote: > > > If CONFIG_DM_DEBUG_SPACE_MAPS is enabled and dm_sm_checker_create() > > > fails, dm_tm_create_internal() would still return success even though it > > > cleaned up all resources it was supposed to have created. > > > > > > Fix the space map checker code to return an appropriate ERR_PTR and have > > > dm_tm_create_internal() check for it with IS_ERR. > > > > > > > I tested the patch and it works. It fails gracefully instead of segfaulting. > > > > device-mapper: reload ioctl failed: Cannot allocate memory > > > > I still do get waring though about large memory allocation. That's a > > separate issue though. > > I put a trace_printk() in ca_create() to see how much memory we are trying > to allocated using kzalloc. And answer is 10485760. Number of blocks > obtained from space map is 2621440. I think this might be happening because > my metadata device size is 10G. It is. My metadata device is 1G and I'm seeing nr_blocks=262144 So kzalloc on your system cannot find 10M of contiguous memory. How does this patch work for you? diff --git a/drivers/md/persistent-data/dm-space-map-checker.c b/drivers/md/persistent-data/dm-space-map-checker.c index 6d7c832..75ab11f 100644 --- a/drivers/md/persistent-data/dm-space-map-checker.c +++ b/drivers/md/persistent-data/dm-space-map-checker.c @@ -89,7 +89,7 @@ static int ca_create(struct count_array *ca, struct dm_space_map *sm) ca->nr = nr_blocks; ca->nr_free = nr_blocks; - ca->counts = kzalloc(sizeof(*ca->counts) * nr_blocks, GFP_KERNEL); + ca->counts = vzalloc(sizeof(*ca->counts) * nr_blocks); if (!ca->counts) return -ENOMEM; -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
