On Wed, 2012-05-23 at 00:50 -0400, Kent Overstreet wrote: > diff --git a/lib/vsprintf.c b/lib/vsprintf.c [] > @@ -1002,6 +1023,7 @@ int format_decode(const char *fmt, struct printf_spec *spec) > case ' ': spec->flags |= SPACE; break; > case '#': spec->flags |= SPECIAL; break; > case '0': spec->flags |= ZEROPAD; break; > + case 'h': spec->flags |= HUNITS; break; > default: found = false; > } > I think that doesn't work well because gcc __attribute__((format(printf, x, y))) verification fails. It's also possible to confuse it with printf's own 'h' / integer precision use. $ cat h.c #include <stdio.h> #include <stdlib.h> int main(int argc, char** argv) { printf("%h02u\n", 1); return 0; } $ gcc h.c h.c: In function ‘main’: h.c:6:3: warning: unknown conversion type character ‘0’ in format [-Wformat] -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel