On 05/08/2012 11:56 PM, Mike Snitzer wrote: > There have been reports of multipath table loads hanging due to > __request_module hanging (for some unknown reason). > > More often than not, the scsi_dh is already available and there is no > need to request_module(). > > Reported-by: Ben Marzinski <bmarzins@xxxxxxxxxx> > Signed-off-by: Mike Snitzer <snitzer@xxxxxxxxxx> > --- > drivers/md/dm-mpath.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c > index 922a338..754f38f 100644 > --- a/drivers/md/dm-mpath.c > +++ b/drivers/md/dm-mpath.c > @@ -718,8 +718,8 @@ static int parse_hw_handler(struct dm_arg_set *as, struct multipath *m) > return 0; > > m->hw_handler_name = kstrdup(dm_shift_arg(as), GFP_KERNEL); > - request_module("scsi_dh_%s", m->hw_handler_name); > - if (scsi_dh_handler_exist(m->hw_handler_name) == 0) { > + if (!try_then_request_module(scsi_dh_handler_exist(m->hw_handler_name), > + "scsi_dh_%s", m->hw_handler_name)) { > ti->error = "unknown hardware handler type"; > ret = -EINVAL; > goto fail; Acked-by: Hannes Reinecke <hare@xxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel