On 03/19/2012 04:20 PM, Alasdair G Kergon wrote:
> On Mon, Mar 19, 2012 at 04:15:28PM +0100, Hannes Reinecke wrote:
>> - if (r < 0 || r == DM_MAPIO_REQUEUE)
>> + if (r < 0 || r == DM_MAPIO_REQUEUE) {
>> mempool_free(mpio, m->mpio_pool);
>> + map_context->ptr = NULL;
>> + }
>
> What about the other places that do mempool_free() ?
> Should they clear it too?
>
Hmm. Probably. It's not strictly speaking required as the other
places will never re-use the context pointer.
But for consistencies sake you are correct.
Will be updating the patch.
> Is it better to swap the statement order - clear it *before*
> freeing i
>
Doubt that should be required.
I would hope that the map_context pointer is protected by
appropriate locks.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
