If, after allocating memory for 'argv' via dm_split_args(...), we take the true branch of 'if (!argc)', we'll jump to the 'out:' label and neglect to free the memory we allocated. We should instead jump to the 'out_argv:' label in that case as far as I can tell. Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx> --- drivers/md/dm-ioctl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Compile tested only. diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index 31c2dc2..1ce84ed 100644 --- a/drivers/md/dm-ioctl.c +++ b/drivers/md/dm-ioctl.c @@ -1437,7 +1437,7 @@ static int target_message(struct dm_ioctl *param, size_t param_size) if (!argc) { DMWARN("Empty message received."); - goto out; + goto out_argv; } table = dm_get_live_table(md); -- 1.7.8.3 -- Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel