On Mon, Aug 01 2011 at 5:00pm -0400, Mikulas Patocka <mpatocka@xxxxxxxxxx> wrote: > Hi > > This is review of dm-block-manager.c: > > > char buffer_cache_name[32]; > sprintf(bm->buffer_cache_name, "dm_block_buffer-%d:%d", > --- it may not fit in 32 bytes. It can accomodate nearly 1 trillion DM devices: dm_block_buffer-253:9999999999 The goal is to move to using a common slab cache per blocksize long before this limit becomes a concern. Mike -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel