Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Mon, 02 May 2011 10:20:54 -0400
Cc: sandeen@xxxxxxxxxx, Mike Snitzer <snitzer@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, device-mapper development <dm-devel@xxxxxxxxxx>, DarkNovaNick@xxxxxxxxx, linux-lvm@xxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Alasdair G Kergon <agk@xxxxxxxxxx>
In-reply-to: <alpine.LFD.2.00.1105021217080.3778@xxxxxxxxxxxxxxxxxxxxxxxxxx> (Lukas Czerner's message of "Mon, 2 May 2011 12:24:33 +0200 (CEST)")
Organization: Oracle
References: <20110413224025.GA18589@xxxxxxxxxx> <20110413234854.GA19793@xxxxxxxxxx> <20110426173213.GA19604@xxxxxxxxxx> <20110428001912.GA14659@xxxxxxxxxx> <20110428075355.GA2190@xxxxxxxxxxxxx> <20110428205935.GA24979@xxxxxxxxxx> <alpine.LFD.2.00.1104291117510.5496@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20110429122454.GL32370@xxxxxxxxxxxxxxxxxxxxx> <alpine.LFD.2.00.1105020857030.3778@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20110502081308.GC8642@xxxxxxxxxxxxxxxxxxxxx> <20110502081925.GA11312@xxxxxxxxxxxxx> <alpine.LFD.2.00.1105021217080.3778@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: device-mapper development <dm-devel@xxxxxxxxxx>
User-agent: Gnus/5.110013 (No Gnus v0.13) Emacs/23.2 (gnu/linux)

>>>>> "Lukas" == Lukas Czerner <lczerner@xxxxxxxxxx> writes:

Lukas> So I gave it a try. First of all the device composed of SSD and
Lukas> spinning disk does export discard_support information properly,
Lukas> however it also advertise discard_zeroes_data which is wrong and
Lukas> possibly dangerous and should be fixed!

I can't reproduce this here. If I mix discard and non-discard devices
things work correctly. discard_zeroes_data also gets cleared if I mix
discard-capable drives where one zeroes and one doesn't.

-- 
Martin K. Petersen	Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Lukas Czerner

References:
- [PATCH] dm snapshot: add discard support to the snapshot-origin target [was: Re: Testing TRIM with LVM]
  - From: Mike Snitzer
- Re: dm snapshot: add discard support to the snapshot-origin target [was: Re: Testing TRIM with LVM]
  - From: Mike Snitzer
- Re: dm snapshot: add discard support to the snapshot-origin target [was: Re: Testing TRIM with LVM]
  - From: Mike Snitzer
- [PATCH] dm snapshot: ignore discards issued to the snapshot-origin target
  - From: Mike Snitzer
- Re: [PATCH] dm snapshot: ignore discards issued to the snapshot-origin target
  - From: Christoph Hellwig
- do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Mike Snitzer
- Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Lukas Czerner
- Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Alasdair G Kergon
- Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Lukas Czerner
- Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Alasdair G Kergon
- Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Christoph Hellwig
- Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Lukas Czerner

Prev by Date: Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
Next by Date: Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
Previous by thread: Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
Next by thread: Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]