Hi,
On Mon, 2010-11-01 at 17:15 +0100, Tejun Heo wrote:
> + if (!IS_ERR(bdev)) {
> + int ret;
> + ret = bd_claim(bdev, dev);
> + if (ret) {
> + blkdev_put(bdev,
> + FMODE_READ | FMODE_WRITE);
Would be a bit cleaner to define ea temporary variable:
fmode_t mode = FMODE_READ | FMODE_WRITE;
Would you to re-send with this little change please?
And ideally, 2 independent patches would be nicer because you fix 2
independent issues.
--
Best Regards,
Artem Bityutskiy (ÐÑÑÑÐ ÐÐÑÑÑÐÐÐ)
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
