On 2010-11-15 22:34, Mike Snitzer wrote: > On Mon, Nov 15 2010 at 3:58pm -0500, > Mike Snitzer <snitzer@xxxxxxxxxx> wrote: > >> Hi Jens, >> >> This may have slipped through while you were traveling? >> >> Patch is also available here: >> https://patchwork.kernel.org/patch/300552/ >> >> Not sure if this change is concerning on a kABI level? > > To be clear: that concern/question was prompted from having taken a > quick glance at lwn's kernel summit "KS2010: ABI status for tracepoints" > coverage: http://lwn.net/Articles/412685/ > > But in that article it clearly states: > "there are to be no stable tracepoints in drivers or filesystems". > > Not sure where that leaves tracepoints for the block layer. Anyway, > seems tracepoint kABI is likely a concern for the future (not the > immediate future). > > So this change would be nice to get in before there is a new tracepoint > kABI-aware sheriff in town. As far as I'm concerned, trace point changes in the block area cannot break existing blktrace (as in cause malfunction). So this patch is fine, I'll pick it up for .38. -- Jens Axboe -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
