Peter Rajnoha tested this this morning and 'dmsetup remove' hung. On Fri, Oct 08, 2010 at 01:53:43PM -0400, Peter Jones wrote: > + if (param->flags & DM_NEW_UUID_FLAG) { > + /* > + * Does this device already have a uuid? > + */ > + if (hc->uuid) { > + DMWARN("asked to change uuid of device with uuid " > + "already set %s %s -> %s", > + param->name, hc->uuid, param->uuid); It's missing dm_put(hd->md) here. > + up_write(&_hash_lock); > + kfree(new_data); > + return ERR_PTR(-EINVAL); Alasdair -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel