Re: [PATCH] virtio-blk: put request that was created to retrieve the device id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] virtio-blk: put request that was created to retrieve the device id
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 21 Sep 2010 17:00:33 -0400
Cc: kvm@xxxxxxxxxxxxxxx, Mike Snitzer <snitzer@xxxxxxxxxx>, john.cooper@xxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, dm-devel@xxxxxxxxxx, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, Vivek Goyal <vgoyal@xxxxxxxxxx>
In-reply-to: <20100917145848.GK30086@xxxxxxxxxx>
References: <20100909160324.GJ30086@xxxxxxxxxx> <20100909175537.GA9589@xxxxxxxxxx> <20100909183554.GK30086@xxxxxxxxxx> <20100909191555.GA14486@xxxxxxxxxx> <20100909194300.GA16908@xxxxxxxxxx> <20100909201445.GA19656@xxxxxxxxxx> <20100909203052.GL30086@xxxxxxxxxx> <20100909210042.GA22092@xxxxxxxxxx> <20100909211504.GA24506@xxxxxxxxxxxxx> <20100917145848.GK30086@xxxxxxxxxx>
Reply-to: device-mapper development <dm-devel@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)

On Fri, Sep 17, 2010 at 09:58:48AM -0500, Ryan Harper wrote:
> Since __bio_map_kern() sets up bio->bi_end_io = bio_map_kern_endio
> (which does a bio_put(bio)) doesn't that ensure we don't leak?

Indeed, that should take care of it.

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- [2.6.36 REGRESSION] Re: virtio-blk: put request that was created to retrieve the device id
  - From: Mike Snitzer

References:
- Re: [REGRESSION][BISECTED] virtio-blk serial attribute causes guest to hang [Was: Re: [PATCH UPDATED 4/5] dm: implement REQ_FLUSH/FUA support for request-based dm]
  - From: Ryan Harper
- Re: [REGRESSION][BISECTED] virtio-blk serial attribute causes guest to hang [Was: Re: [PATCH UPDATED 4/5] dm: implement REQ_FLUSH/FUA support for request-based dm]
  - From: Mike Snitzer
- Re: [REGRESSION][BISECTED] virtio-blk serial attribute causes guest to hang [Was: Re: [PATCH UPDATED 4/5] dm: implement REQ_FLUSH/FUA support for request-based dm]
  - From: Ryan Harper
- Re: [REGRESSION][BISECTED] virtio-blk serial attribute causes guest to hang [Was: Re: [PATCH UPDATED 4/5] dm: implement REQ_FLUSH/FUA support for request-based dm]
  - From: Mike Snitzer
- Re: [REGRESSION][BISECTED] virtio-blk serial attribute causes guest to hang [Was: Re: [PATCH UPDATED 4/5] dm: implement REQ_FLUSH/FUA support for request-based dm]
  - From: Mike Snitzer
- Re: [REGRESSION][BISECTED] virtio-blk serial attribute causes guest to hang [Was: Re: [PATCH UPDATED 4/5] dm: implement REQ_FLUSH/FUA support for request-based dm]
  - From: Mike Snitzer
- Re: [REGRESSION][BISECTED] virtio-blk serial attribute causes guest to hang [Was: Re: [PATCH UPDATED 4/5] dm: implement REQ_FLUSH/FUA support for request-based dm]
  - From: Ryan Harper
- [PATCH] virtio-blk: put request that was created to retrieve the device id
  - From: Mike Snitzer
- Re: [PATCH] virtio-blk: put request that was created to retrieve the device id
  - From: Christoph Hellwig
- Re: [PATCH] virtio-blk: put request that was created to retrieve the device id
  - From: Ryan Harper

Prev by Date: Re: Help ! : device-mapper: reload ioctl failed: Invalid argument
Next by Date: [PATCH] block: set the bounce_pfn to the actual DMA limit rather than to max memory
Previous by thread: Re: [PATCH] virtio-blk: put request that was created to retrieve the device id
Next by thread: [2.6.36 REGRESSION] Re: virtio-blk: put request that was created to retrieve the device id
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]