Hello, Jan. On 08/12/2010 11:24 PM, Jan Kara wrote: > On Thu 12-08-10 14:41:30, Tejun Heo wrote: >> Propagate deprecation of REQ_HARDBARRIER and new REQ_FLUSH/FUA >> interface to upper layers. >> >> * WRITE_BARRIER is marked deprecated and WRITE_FLUSH, WRITE_FUA and >> WRITE_FLUSH_FUA are added. >> >> * REQ_COMMON_MASK now includes REQ_FLUSH | REQ_FUA so that they are >> copied from bio to request. >> >> * BH_Ordered is marked deprecated and BH_Flush and BH_FUA are added. > > Deprecating BH_Ordered is fine but I wouldn't introduce new BH flags for > this. BH flags should be used for buffer state, not for encoding how the > buffer should be written (there were actually bugs in the past because of > this). Being able to set proper flags when calling submit_bh() in the rw > parameter is enough. Ah, okay, I was just trying to match the BH_Ordered usage but you're saying just requiring submit_bh() users to specify appropriate REQ_* (or WRITE_*) in @rw is okay, right? I'll drop the bh part then. Thanks. -- tejun -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
