Malahal Naineni wrote: > Christophe Varoqui [christophe.varoqui@xxxxxxxxx] wrote: >> > 3. We could rename the devices instead of reload -- really fixing this! >> > >> >> This one seems safe. > > This is where I was heading. I did some investigation and found that we > really need to rename to wwid based names before we finally rename to > the intended name. So we may actually have two passes just to rename > (first to wwid based names and then to actual names). Also the current > code doesn't do rename followed by reload even if it is needed. Someone > sets friendly name and some other defaults that need reload like path > grouping policy etc, we just rename! Probably a bug in itself. > You sure? I would rather rely on device-mapper uuids here. Point is that we a) use 'mpath-<wwid>' as uuid for multipath generated tables anyway and b) uuids are a primary key for device-mapper, too. So we can use the known naming scheme for the uuid to regenerate the wwid; with this we can identify/access the device and we should be able to make do with just one pass. Two passes have the serious disadvantage of generating yet another set of meaningless uevents, which then again have to be handled/ignored etc. I'll be sending a patch to simplify dm_get_name() to illustrate my point. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
