On 2010-07-01 12:49, FUJITA Tomonori wrote: > This patchset fixes page leak issue in discard commands with unprep > facility that James posted: > > http://marc.info/?l=linux-scsi&m=127791727508214&w=2 > > The 1/3 patch adds unprep facility to the block layer (identical to > what James posted). > > The 2/3 patch frees a page for discard commands by using the unprep > facility. James' original patch doesn't work since it accesses to > rq->bio in q->unprep_rq_fn. We hit oops since q->unprep_rq_fn is > called when all the data buffer (req->bio and scsi_data_buffer) in the > request is freed. > > I use rq->buffer to keep track of an allocated page as the block layer > sets rq->buffer to the address of bio's page. scsi-ml (and llds) don't > use rq->buffer (rq->buffer is set to NULL). So I can't say that I like > it lots. Any other way to do that? > > The 3/3 path just removes the dead code. I've queued up these three for 2.6.36. -- Jens Axboe -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
