On Sun, Jun 27 2010 at 5:39am -0400,
Christoph Hellwig <hch@xxxxxx> wrote:
> On Sat, Jun 26, 2010 at 03:56:51PM -0400, Mike Snitzer wrote:
> > Don't alloc discard bio with a biovec in blkdev_issue_discard. Doing so
> > means bio_has_data() will not be true until the SCSI layer adds the
> > payload to the discard request via blk_add_request_payload.
> >
> > bio_{enable,disable}_inline_vecs are not expected to be widely used so
> > they were exported using EXPORT_SYMBOL_GPL.
>
> Why do we need them exported at all?
Hmm, good point!
> Also some comments on these functions would be useful.
OK.
> Otherwise it looks good to me.
Thanks, I'll get a v2 of this patch out.
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
