Hi Will, n 05/15/2010 10:41 AM +0900, Will Drewry wrote: > In addition, it ensures that public functions are available that > allow mapped devices and tables to be created and associated > with the shared code paths with dm-ioctl: > - suspend flags are available snip > diff --git a/drivers/md/dm.h b/drivers/md/dm.h > index bad1724..782d867 100644 > --- a/drivers/md/dm.h > +++ b/drivers/md/dm.h > @@ -17,12 +17,6 @@ > #include <linux/hdreg.h> > > /* > - * Suspend feature flags > - */ > -#define DM_SUSPEND_LOCKFS_FLAG (1 << 0) > -#define DM_SUSPEND_NOFLUSH_FLAG (1 << 1) > - > -/* > * Type of table and mapped_device's mempool > */ > #define DM_TYPE_NONE 0 > diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h > index 1381cd9..6c1c230 100644 > --- a/include/linux/device-mapper.h > +++ b/include/linux/device-mapper.h > @@ -215,6 +215,18 @@ void dm_set_mdptr(struct mapped_device *md, void *ptr); > void *dm_get_mdptr(struct mapped_device *md); > > /* > + * Export the device via the ioctl interface (uses mdptr). > + */ > +int dm_ioctl_export(struct mapped_device *md, const char *name, > + const char *uuid); > + > +/* > + * Suspend feature flags > + */ > +#define DM_SUSPEND_LOCKFS_FLAG (1 << 0) > +#define DM_SUSPEND_NOFLUSH_FLAG (1 << 1) > + > +/* > * A device can still be used while suspended, but I/O is deferred. > */ > int dm_suspend(struct mapped_device *md, unsigned suspend_flags); Why do you need suspend feature flags? I think no feature is needed (specifying '0' is enough) to make/suspend a dm device at boot time (although I have looked at only this flag part). Am I missing something? Thanks, Kiyoshi Ueda -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
