On Thu, Mar 04 2010 at 8:22am -0500, Mike Snitzer <snitzer@xxxxxxxxxx> wrote: > On Thu, Mar 04 2010 at 5:11am -0500, > Mikulas Patocka <mpatocka@xxxxxxxxxx> wrote: > > > I went through your kernel patch and uploaded a new version at > > http://people.redhat.com/mpatocka/patches/kernel/new-snapshots/r16/ . It > > contains fix for this 100% usage. It contains most of your changes (I > > rolled back that cycle change). > > OK, I have made further edits that layered ontop of my other changes > (primarily just making use of __func__ rather than hardcoding the > function name in ERROR messages). I'll have a look at your r16 and > hopefully they'll apply there too. I've uploaded my edits to r16 here: http://people.redhat.com/msnitzer/patches/multisnap/kernel/2.6.33/r16a/ You can see the edits here: http://people.redhat.com/msnitzer/patches/multisnap/kernel/2.6.33/r16a/r16_edits.patch Boils down to: * use __func__ rather than hardcoding the function name - this fixed ~3 inconsistencies (incorrect function names) and should help if/when we do any function renaming in later phases of review * s/Tomonorig/Tomonori/ * a few more typo fixups * a few more whitespace cleanups. I'd appreciate it if you pull these in for the basis of any follow-on release you make. Also, I'm working to improve Documentation/device-mapper/dm-multisnapshot.txt I'll share this a bit later (hopefully today). Mike -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
