On Mon, 21 Dec 2009, Paul Mundt wrote: > > Example picked totally at random: > > > > set_le_ih_k_offset(ih, > > le_ih_k_offset(ih) + > > (tb-> > > lbytes << > > (is_indirect_le_ih > > (ih) ? tb->tb_sb-> > > s_blocksize_bits - > > UNFM_P_SHIFT : > > 0))); > > > > See how everything is nicely aligned to 80 cols? > > > > > > Generally, don't look at this function after having a good lunch you want > > to keep. You have been warned. > > > This isn't a valid example, as it wasn't written by a human. This is the > result of Lindent being run blindly on the file and nothing more. > > Try again. But having hard rule imposed on everyone to stick with 80-char rule makes people to do exactly this kind of things (blindly running indent -l80 and believing that it makes the code more readable because it is CodingStyle-compliant(tm)). -- Jiri Kosina SUSE Labs, Novell Inc. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
