On Thu, Dec 17, 2009 at 09:12:24PM -0800, Joe Perches wrote: > On Thu, 2009-12-17 at 23:29 -0500, Valdis.Kletnieks@xxxxxx wrote: > > Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non- > > continuation line, it's probably in its rights to whinge. > > grep -r -P '^\t{7:}(?!(.*,$|.*\);$))' . | more > > produces a whole lot of "this can't end well" output. > > I think this is a good test to add to checkpatch. > > Add 105 character long line WARN test > Add 80 character long line STRICT test > Add 6+ leading indent tabs test, consider restructuring > This looks like a reasonable compromise. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel