As this removes partitions for a list of devices, it could leak
a large number of file descriptors.
Reported-by: David Binderman <dcb314@xxxxxxxxxxx>
From: crrodriguez@xxxxxxxxxxxx
Signed-off-by: NeilBrown <neilb@xxxxxxx>
---
lib/device/partition.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- dmraid-16.orig/lib/device/partition.c
+++ dmraid-16/lib/device/partition.c
@@ -30,12 +30,15 @@ _remove_subset_partitions(struct lib_con
/* There is no way to enumerate partitions */
for (part.pno = 1; part.pno <= 256; part.pno++) {
if (ioctl(fd, BLKPG, &io) < 0 && errno != ENXIO &&
- (part.pno < 16 || errno != EINVAL))
+ (part.pno < 16 || errno != EINVAL)) {
+ close(fd);
LOG_ERR(lc, 0,
"removing part %d from %s: %s\n",
part.pno, rd->di->path,
strerror(errno));
+ }
}
+ close(fd);
}
return 1;
}
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
