On Sat, Oct 03 2009, Ingo Molnar wrote:
>
> * Mike Galbraith <efault@xxxxxx> wrote:
>
> > unsigned int cfq_desktop;
> > + unsigned int cfq_desktop_dispatch;
>
> > - if (cfq_cfqq_idle_window(cfqq) && cfqd->rq_in_driver[BLK_RW_ASYNC])
> > + if (cfq_cfqq_idle_window(cfqq) && cfqd->rq_in_driver[BLK_RW_ASYNC]) {
> > + cfqd->desktop_dispatch_ts = jiffies;
> > return 0;
> > + }
>
> btw., i hope all those desktop_ things will be named latency_ pretty
> soon as the consensus seems to be - the word 'desktop' feels so wrong in
> this context.
>
> 'desktop' is a form of use of computers and the implication of good
> latencies goes far beyond that category of systems.
I will rename it, for now it doesn't matter (lets not get bogged down in
bike shed colors, please).
Oh and Mike, I forgot to mention this in the previous email - no more
tunables, please. We'll keep this under a single knob.
--
Jens Axboe
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
